Re: Move 'with-buffer-modified-unmodified' to simple.el

[Stefan Monnier]

> How should we determine if the extra bindings in `with-silent-modifications’
> aren’t right? In my understanding `with-silent-modifications’ should only be
> used when changing text properties and if you actually insert something you
> should use `with-buffer-modified-unmodified’. Is that correct?

I think so, yes.

> Looking though the result of the grep, I see some text property changes and
> some content changes.

How many cases (approximately) involve content changes?

> But the content changes seems to appear in program-generated buffers
> so I’m not sure if `with-silent-modifications’ would do any
> harm anyway.

`with-silent-modifications’ would prevent jit-lock from doing its job,
so it would interfere with the use (within that buffer) of any package
that depends on jit-lock, such as font-lock-mode, nlinum-mode,
nhexl-mode, goto-address-mode, bug-reference-mode, glasses-mode.


        Stefan