RE: master baf331e 3/3: Rename replace-in-string to string-replace

[Drew Adams]

> > Now we'll have `replace-string' and `string-replace'?
> 
> I don't care much which name we use, but I mist admit that I'm always
> annoyed by `string-match` vs `match-string` so I'd be happy if we
> avoided this snag for `replace-string' vs `string-replace'?

+1.

There's a lot of name legacy in Emacs.  There's
certainly room for some crusader to go hog-wild
renaming things.  And then for another to come
along later and re-rename in some other direction.

As usual, we're better off considering any possible
renamings one case at a time.

Following any "Consistency Now!" pied-piping is
likely to lead to some buyer's remorse at some
point.  Not to mention a lot of time spent,
including by users trying to deal with such name
changes.