emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 03/16] Stop checking the constant default for enable_multi


From: Eli Zaretskii
Subject: Re: [PATCH v2 03/16] Stop checking the constant default for enable_multibyte_characters
Date: Tue, 01 Dec 2020 18:52:03 +0200

> From: Spencer Baugh <sbaugh@catern.com>
> Date: Sat, 21 Nov 2020 21:34:32 -0500
> Cc: Spencer Baugh <sbaugh@catern.com>, Arnold Noronha <arnold@tdrhq.com>,
>  Stefan Monnier <monnier@iro.umontreal.ca>, Dmitry Gutov <dgutov@yandex.ru>
> 
> The default is a constant "t", and can't be changed. So we don't need
> to check it.

This changeset is unrelated to the main issue.  It might be a
prerequisite for applying the main changeset, but it can also be
applied if the main changeset is not installed.  Right?  If so, I
don't object, and in general the parts of your patch series that can
stand on their own right should be so identified, so that we install
them separately.

> @@ -2510,8 +2509,6 @@ usage:  (make-pipe-process &rest ARGS)  */)
>        }
>      else if (!NILP (Vcoding_system_for_write))
>        val = Vcoding_system_for_write;
> -    else if (NILP (BVAR (current_buffer, enable_multibyte_characters)))
> -      val = Qnil;

Hmm... not sure I understand why you suggest to remove this.  It
doesn't refer to buffer_defaults.

Again, the log message is missing, but otherwise okay.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]