Re: [PATCH v2 06/16] Use bset_* functions instead of BVAR

[Eli Zaretskii]

> From: Spencer Baugh <sbaugh@catern.com>
> Date: Sat, 21 Nov 2020 21:34:35 -0500
> Cc: Spencer Baugh <sbaugh@catern.com>, Arnold Noronha <arnold@tdrhq.com>,
>  Stefan Monnier <monnier@iro.umontreal.ca>, Dmitry Gutov <dgutov@yandex.ru>
> 
> We move bset_save_length to buffer.h, and expand usage of the
> pre-existing bset_last_selected_window and
> bset_enable_multibyte_characters functions.
> 
> This removes some usage of BVAR as an lvalue, necessary for changing
> BVAR into a function call.

This is problematic.  Inline functions are only fast in optimized
builds, so this punishes people who run unoptimized debug builds,
which is true for many developers.  I'd prefer to have a macro for
that, okay?  And we don't actually need a separate macro for each
variable, right?

Thanks.