Re: [PATCH v2 10/16] Add and use KILL_PER_BUFFER_VALUE

[Eli Zaretskii]

> From: Spencer Baugh <sbaugh@catern.com>
> Date: Sat, 21 Nov 2020 21:34:39 -0500
> Cc: Spencer Baugh <sbaugh@catern.com>, Arnold Noronha <arnold@tdrhq.com>,
>  Stefan Monnier <monnier@iro.umontreal.ca>, Dmitry Gutov <dgutov@yandex.ru>
> 
> This improves clarity and removes usage of idx.

Same comment as earlier regarding changes related to idx.

As for clarity: you introduced an inline function, which will make the
code slower in unoptimized builds.  If you think the benefits from
bringing these two operations together will benefit readability, let's
make that a macro, not a function.

Thanks.