Re: [PATCH v2 12/16] Rearrange set_internal for buffer forwarded symbols

[Eli Zaretskii]

> From: Spencer Baugh <sbaugh@catern.com>
> Date: Sat, 21 Nov 2020 21:34:41 -0500
> Cc: Spencer Baugh <sbaugh@catern.com>, Arnold Noronha <arnold@tdrhq.com>,
>  Stefan Monnier <monnier@iro.umontreal.ca>, Dmitry Gutov <dgutov@yandex.ru>
> 
> Previously, we unnecessarily called store_symval_forwarding even after
> calling set_default_internal.  store_symval_forwarding would have no
> additional effect after a call to set_default_internal.

Hmm... I don't think I follow.  can you explain why
store_symval_forwarding would have no effect in that case?

> Now, we don't call store_symval_forwarding if we've called
> set_default_internal.  As a consequence, we can also move the call to
> SET_PER_BUFFER_VALUE_P into store_symval_forwarding, where it's closer
> to the per-buffer-value actually being set, which improves clarity.
> 
> We'll later move the effect of SET_PER_BUFFER_VALUE_P into
> set_per_buffer_value, so they need to be together.

Once again, if this is some preparation for a next patch in the
series, let's make all those changes in one go, skipping any
intermediate steps; they are just a distraction.

Given these comments, I'm not sure I understand whether this patch is
part of the main change or some cleanup (or a mix of them).  Please
clarify (and separate the cleanup if needed).