Re: Some dynamic module questions

[Philipp Stephani]

Am Do., 3. Dez. 2020 um 09:42 Uhr schrieb Helmut Eller <eller.helmut@gmail.com>:
>
> On Thu, Dec 03 2020, Lars Ingebrigtsen wrote:
>
> > Philipp Stephani <p.stephani2@gmail.com> writes:
> >
> >> Unibyte support has now been requested at least three times
> >> independently (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23487,
> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34873, this thread),
> >> showing how much users care about it.
> >
> > Sorry; I haven't followed this thread -- but if you're talking about
> > making unibyte strings in modules, this was addded in
> > 12175a339e2a2214fdd0ab4e16d8d8b1e92a78d3.
>
> My question is mostly if copy_string_contents can also be used for
> unibyte strings or if there should be a separate
> copy_unibyte_string_contents.
>
> Encoding unibyte strings in UTF-8 probably doesn't make much sense, or
> does it?  And adding a trailing NUL byte is not useful for binary data.

I agree that there should be a copy_unibyte_string_contents as well.