emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri


From: Eli Zaretskii
Subject: Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property
Date: Sun, 13 Dec 2020 17:05:02 +0200

> From: Evgeny Zajcev <zevlg@yandex.ru>
> Date: Sat, 12 Dec 2020 23:42:36 +0300
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> > > +@defun svg-embed-base-uri-image svg relative-filename &rest args
> > > +To @var{svg} add an embedded (raster) image placed at
> > > +@var{relative-filename}.  @var{relative-filename} is searched inside
> > > +@code{file-name-directory} of the @code{:base-uri} svg image property.
> >
> > This is the only place in the manual where the :base-uri attribute is
> > mentioned.  Can we please add some minimal description of what that
> > attribute does and how it is useful?
> 
> This is only function, where `:base-uri` could be useful

Then I think its documentation should say something about what a "base
URI" is.

> > > +This improves the performance of embedding large images.
> >
> > What is "this" that improves the performance, and how does it do so?
> >
> 
> "this" - having support for `:base_uri`

Yes, but _why_ does having the base URI improve the performance?

> We should at least hint at the improvement, without that this sentence
> > sounds puzzling.
> >
> >
> I'll try my best in rewording this, however take into account that I'm very
> bad at wording in English.  Maybe it is better for someone else to write
> docs for it?

Just explain it in your words, and I will reword if needed.

> I'll compose patch you want a bit later

Thanks in advance.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]