[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables |
Date: |
Sun, 04 Apr 2021 10:15:34 +0300 |
> From: Spencer Baugh <sbaugh@catern.com>
> Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca
> Date: Sat, 03 Apr 2021 16:53:42 -0400
>
> | Unmodified Emacs | 6.529 |
> | My changes | 6.610 |
> | My changes + no default for bidi_display_reordering | 6.582 |
>
> About a 1-2% slowdown from my changes.
>
> I tried removing the default for bidi_display_reordering; customizing
> bidi-display-reording is explicitly unsupported anyway, so I think
> changing its behavior is reasonable.
>
> That improved performance but unfortunately not enough to fully match an
> unmodified Emacs. Not sure what else to do.
Thanks.
I'm okay with 1-2% slowdown in redisplay, and I don't want to remove
the default value from bidi-display-reordering. Let's hear if someone
else feels that such slowdown in redisplay is a bother; if not, it
sounds like a good tradeoff.
If someone has other good benchmarks before we make the decision,
please speak up.