On Jun 6, 2021, at 18:13, Alan Third <alan@idiocy.org> wrote:
On Sun, Jun 06, 2021 at 04:48:32PM +1000, Paul W. Rankin wrote:
No problemo. Revised patch attached.
Thanks. I've pushed it to master.
--
Alan Third
I found the following issues with this macOS native tab commit.
Does anyone else encounter the same problems?
1) Frame height increases (even if frame-inhibit-implied-resize is t).
attachment:
01_macOS-tab-issue-increases-height.gif
01_macOS-tab-issue-increases-height-2.gif … (sets frame-inhibit-implied-resize t)
2) New tab name is ‘emacs’ instead of buffer name.
Does anyone else encounter the same problems?
1) Frame height increases (even if frame-inhibit-implied-resize is t).
attachment:
01_macOS-tab-issue-increases-height.gif
01_macOS-tab-issue-increases-height-2.gif … (sets frame-inhibit-implied-resize t)
2) New tab name is ‘emacs’ instead of buffer name.
(even if C-x 5 C-f `find-file-other-frame’)
attachment:
02_macOS-tab-issue-odd-tab-name.gif
3) Tabs are not shown in fullscreen.
attachment:
03_macOS-tab-fullscreen-expected-textedit.gif. .. e.g. macOS Test Edit app
03_macOS-tab-issue-fullscreen-emacs.gif
4) Doom modeline is not get focused when tab is closed.
attachment:
02_macOS-tab-issue-odd-tab-name.gif
3) Tabs are not shown in fullscreen.
attachment:
03_macOS-tab-fullscreen-expected-textedit.gif. .. e.g. macOS Test Edit app
03_macOS-tab-issue-fullscreen-emacs.gif
4) Doom modeline is not get focused when tab is closed.
This could be a ‘doom-modeline’ problem.
attachment:
04_macOS-tab-issue-doom-modeline-focus.gif
5) Native tabbing doesn’t work with (ns-transparent-titlebar . t) frame parameter.
This could be a limitation of macOS, and expected behavior.
attachment:
04_macOS-tab-issue-doom-modeline-focus.gif
5) Native tabbing doesn’t work with (ns-transparent-titlebar . t) frame parameter.
This could be a limitation of macOS, and expected behavior.
Regards,
—Naofumi
In GNU Emacs 28.0.50 (build 3, x86_64-apple-darwin20.5.0, NS appkit-2022.50 Version 11.4 (Build 20F71))
of 2021-06-06 built on hyperion.local
Repository revision: 2207f9adccc0411b7ad73a3703f16250d7f8e139
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2022
System Description: macOS 11.4
Configured features:
ACL DBUS GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY
KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS XIM ZLIB
Important settings:
value of $LANG: ja_JP.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
japan-util iso-transl tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind kqueue cocoa ns
lcms2 multi-tty make-network-process emacs)
Memory information:
((conses 16 53338 8028)
(symbols 48 6551 1)
(strings 32 17888 2138)
(string-bytes 1 590179)
(vectors 16 14083)
(vector-slots 8 253556 9292)
(floats 8 21 37)
(intervals 56 197 0)
(buffers 992 10))
of 2021-06-06 built on hyperion.local
Repository revision: 2207f9adccc0411b7ad73a3703f16250d7f8e139
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2022
System Description: macOS 11.4
Configured features:
ACL DBUS GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY
KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS XIM ZLIB
Important settings:
value of $LANG: ja_JP.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
japan-util iso-transl tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind kqueue cocoa ns
lcms2 multi-tty make-network-process emacs)
Memory information:
((conses 16 53338 8028)
(symbols 48 6551 1)
(strings 32 17888 2138)
(string-bytes 1 590179)
(vectors 16 14083)
(vector-slots 8 253556 9292)
(floats 8 21 37)
(intervals 56 197 0)
(buffers 992 10))
