emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-28 d3a832a: Simplify hack-read-symbol-shorthands again (bug#50


From: João Távora
Subject: Re: emacs-28 d3a832a: Simplify hack-read-symbol-shorthands again (bug#50946)
Date: Mon, 4 Oct 2021 08:32:51 +0100

On Mon, Oct 4, 2021, 03:02 Stefan Monnier <monnier@iro.umontreal.ca> wrote:

I know mule.el is very namespace-unclean, but could we try and not make
things worse.

Use shorthands! ;-)

  E.g. we could call this `shorthands--hack-read-symbol-function`?

I was kidding. Go ahead.

 Variables" parsing.
> +  (alist-get 'read-symbol-shorthands (hack-local-variables--find-variables)))

Same here?

Same, yes, it's the same variable.

BTW, we could also skip the var and do

                       (and (fboundp 'shorthands--hack-read-symbol)
                            (shorthands--hack-read-symbol))

If the function is set up late enough, I guess.  Else it'll make the loop described. I always find variables a cleaner API than fboundp. 

But feel free to change, this the part of the feature where I have no opinion. As long as it passes the tests...

João


reply via email to

[Prev in Thread] Current Thread [Next in Thread]