emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Moving kbd to subr.el


From: Lars Ingebrigtsen
Subject: Re: Moving kbd to subr.el
Date: Sat, 16 Oct 2021 17:55:37 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Stefan Kangas <stefankangas@gmail.com> writes:

> Certainly.  Now done in commit e082a16284 and 8ee63604e3.

Thanks!

> We might as well fix the (<= 0 ch 127) bit, as I didn't do that in my patch.
>
> (I know there are different styles, but I personally often think it's
> nice to put such cleanups in their own commits to facilitate later
> bisecting.)

Sure.  I waffle between the two styles because I don't want to add noise
(so fewer commits are better), but at the same time, keeping cleanups
separate makes the functional changes easier to comprehend (so more
commits are better).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



reply via email to

[Prev in Thread] Current Thread [Next in Thread]