Re: master 1914d94 2/2: Change how Dired displays available space

[Michael Albinus]

larsi@gnus.org (Lars Ingebrigtsen) writes:

Hi Lars,

>     Change how Dired displays available space
>
>     * doc/emacs/dired.texi (Misc Dired Features): Document it (bug#23812).
>     * lisp/dired.el (dired-free-space): New user option.
>     (dired-insert-directory): Use it from here.
>     (dired--insert-disk-space): New function that uses the user option.
>
>     * lisp/files.el (insert-directory): Don't transform "total" here.
>     * lisp/ls-lisp.el (ls-lisp--insert-directory): Or here.  Instead
>     just leave the "total <num>" bit alone, and let Dired transform it.

Hmm. insert-directory can be used w/o being called from dired. And there
are further implementations of insert-directory, because it uses file
name handlers. So these functions must be adapted as well.

--8<---------------cut here---------------start------------->8---
$ find . -name "*.el" -exec grep --color=auto -i -nH -E 
'defun.+-insert-directory' \{\} +
./eshell/em-ls.el:249:(defun eshell-ls--insert-directory
./dired.el:1506:(defun dired-insert-directory (dir switches &optional file-list 
wildcard hdr)
./net/tramp-smb.el:1047:(defun tramp-smb-handle-insert-directory
./net/tramp-fuse.el:111:(defun tramp-fuse-handle-insert-directory
./net/tramp-sh.el:2534:(defun tramp-sh-handle-insert-directory
./net/ange-ftp.el:4579:(defun ange-ftp-real-insert-directory (&rest args)
./net/ange-ftp.el:4605:(defun ange-ftp-insert-directory (file switches 
&optional wildcard full)
./net/tramp-archive.el:632:(defun tramp-archive-handle-insert-directory
./net/tramp.el:3787:(defun tramp-handle-insert-directory
./net/tramp-crypt.el:785:(defun tramp-crypt-handle-insert-directory
./find-lisp.el:241:(defun find-lisp-insert-directory (dir
./ls-lisp.el:259:(defun ls-lisp--insert-directory (orig-fun file switches 
&optional wildcard full-directory-p)
./ls-lisp.el:343:(defun ls-lisp-insert-directory
--8<---------------cut here---------------end--------------->8---

Granted, most of them are from Tramp, but there could be also other
implementations in the wild.

Is there a shiny reason to move this functionality from insert-directory
to dired-insert-directory? A discussion about, or at least a trigger for
this change (aka announcement in etc/NEWS), would have been appreciated.

Best regards, Michael.