Re: Variable pitch text filling

[Feng Shu]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "Feng Shu" <tumashu@163.com>
>> Cc: casouri@gmail.com,  larsi@gnus.org,  emacs-devel@gnu.org
>> Date: Fri, 03 Dec 2021 16:51:41 +0800
>> 
>> Maybe we should conside the below feature:
>> 1. Prevent minibuffer/mode/header/tab-line from shaking up and down 
>> 2. Provide a simple fontset config UI? customize-fontset?
>> 3. line-height-factor
>
> First, I don't see how any feature that affects the height of the
> lines could be useful for horizontal character-spacing, in general.
>
> Second, I already implemented 1 and 3, and you rejected the results as

the patch implemented 1, do you mean the below?

+++ b/src/window.c
@@ -5246,7 +5246,10 @@ grow_mini_window (struct window *w, int delta)
 {
   struct frame *f = XFRAME (w->frame);
   int old_height = window_body_height (w, true);
-  int min_height = FRAME_LINE_HEIGHT (f);
+  int min_height =
+    FLOATP (Vline_height_factor)
+    ? FRAME_LINE_HEIGHT (f) * XFLOAT_DATA (Vline_height_factor)
+    : FRAME_LINE_HEIGHT (f);
 
   eassert (MINI_WINDOW_P (w));
 
@@ -5279,7 +5282,11 @@ grow_mini_window (struct window *w, int delta)
 shrink_mini_window (struct window *w)
 {
   struct frame *f = XFRAME (w->frame);
-  int delta = window_body_height (w, true) - FRAME_LINE_HEIGHT (f);
+  int min_line_height =
+    FLOATP (Vline_height_factor)
+    ? FRAME_LINE_HEIGHT (f) * XFLOAT_DATA (Vline_height_factor)
+    : FRAME_LINE_HEIGHT (f);
+  int delta = window_body_height (w, true) - min_line_height;
 
   eassert (MINI_WINDOW_P (w));
 
diff --git a/src/xdisp.c b/src/xdisp.c



> unsatisfactory, so this is off the table.
>
> As for easier customization of fontsets: patches are welcome, of
> course.  But again, I'm not sure it will fix the problem discussed
> here, since no one has yet come up with a list of fonts where the
> problems that bother you are resolved.

--