[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Merging the pgtk branch
From: |
Yuuki Harano |
Subject: |
Re: Merging the pgtk branch |
Date: |
Mon, 06 Dec 2021 01:01:17 +0900 (JST) |
On Sun, 05 Dec 2021 16:08:05 +0200,
Eli Zaretskii <eliz@gnu.org> wrote:
>> I thought that gui_set_border_width could change the border width of a frame.
>> But there is the code:
>> ---
>> if (FRAME_NATIVE_WINDOW (f) != 0)
>> error ("Cannot change the border width of a frame");
>> ---
>> I was confused, and added #ifndef around it.
>>
>> I don't know about the function.
>> What is it for?
>
> It's for setting the width of the "external border" of the frame,
> something that window managers generally disallow. Doesn't PGTK
> define FRAME_NATIVE_WINDOW to return non-zero for any GUI frame? If
> so, you don't have to #ifdef this, it will work as with any other
> window-system.
Thanks.
I reverted those changes.
And I think I did all the fixes which are necessary by review comments by you.
--
Yuuki Harano
- Re: Merging the pgtk branch, Eli Zaretskii, 2021/12/05
- Re: Merging the pgtk branch,
Yuuki Harano <=
- Re: Merging the pgtk branch, Eli Zaretskii, 2021/12/05
- Re: Merging the pgtk branch, Po Lu, 2021/12/05
- Re: Merging the pgtk branch, Po Lu, 2021/12/05
- Re: Merging the pgtk branch, Yuuki Harano, 2021/12/06
- Re: Merging the pgtk branch, Po Lu, 2021/12/06
- Re: Merging the pgtk branch, Yuuki Harano, 2021/12/06
- Re: Merging the pgtk branch, Po Lu, 2021/12/09
- Re: Merging the pgtk branch, Po Lu, 2021/12/18
- Re: Merging the pgtk branch, Yuuki Harano, 2021/12/18
- Re: Merging the pgtk branch, Eli Zaretskii, 2021/12/18