Re: master 3d38d1d: Add sqlite3 support to Emacs

[Stefan Kangas]

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit 3d38d1d1345aa65c4018b42e6c648606e32216f8
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Add sqlite3 support to Emacs

Great, thank you.  Some minor nits below:

> diff --git a/lisp/sqlite.el b/lisp/sqlite.el
> new file mode 100644
> index 0000000..a47689c
> --- /dev/null
> +++ b/lisp/sqlite.el
> @@ -0,0 +1,42 @@
> +;;; sqlite.el --- Tests for empty.el  -*- lexical-binding: t; -*-

Is that file header correct?

> +This file is based on the emacs-sqlite3 package written by Syohei
> +YOSHIDA <syohex@gmail.com>, which can be found at:
> +
> +   https://github.com/syohex/emacs-sqlite3

Consider adding here: "Integrated into Emacs by Lars Ingebrigtsen."

> +DEFUN ("sqlite-load-extension", Fsqlite_load_extension,
> +       Ssqlite_load_extension, 2, 2, 0,
> +       doc: /* Load a an SQlite module into DB.
                       ^^^^

"an"

> +DEFUN ("sqlite-more-p", Fsqlite_more_p, Ssqlite_more_p, 1, 1, 0,
> +       doc: /* Say whether there's any further results in SET.  */)
                              ^^^^^^^

Should that be "there are"?

> +;;; sqlite-tests.el --- Tests for sqlite.el  -*- lexical-binding: t; -*-
[snip]
> +;; (setq db (sqlite-open))

Left-over debug statement?