[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-28 6170c50: Fix regression in help-mode prompt
From: |
Stephen Berman |
Subject: |
Re: emacs-28 6170c50: Fix regression in help-mode prompt |
Date: |
Tue, 14 Dec 2021 15:01:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
On Tue, 14 Dec 2021 15:09:06 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Tue, 14 Dec 2021 03:30:22 -0800
>>
>> eliz@gnu.org (Eli Zaretskii) writes:
>>
>> > diff --git a/lisp/help-macro.el b/lisp/help-macro.el
>> > index 1fa9d82..b3c7e23 100644
>> > --- a/lisp/help-macro.el
>> > +++ b/lisp/help-macro.el
>> > @@ -165,14 +165,18 @@ and then returns."
>> > (let ((cursor-in-echo-area t)
>> > (overriding-local-map local-map))
>> > (setq key (read-key-sequence
>> > - (format "Type one of the options
>> > listed%s: "
>> > + (format "Type one of listed options%s: "
>>
>> Are we sure that this is an improvement? I find the old text more natural.
>
> I didn't change the text to improve it, I changed it to make it
> shorter. Because otherwise, when we echo the keys typed by the user,
> they overflow the (default) window width, and that resizes the
> mini-window, which causes an unpleasant effect of scrolling the Help
> window.
>
> If you can suggest a different solution that avoids the resizing,
> please do.
Is this about the *Metahelp* buffer displayed by typing `C-h ?'? Then I
think it's sufficient to prompt with "Type one of the options%s: ",
since the buffer containing the options is in plain view.
Steve Berman