Re: master b2e6e95581: Only reset buffer-local buffer-stale-function in make-indirect-buffer

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +      if (!NILP (Flocal_variable_p (Qbuffer_stale_function, base_buffer)))
>> +    Fset (Qbuffer_stale_function, Qbuffer_stale__default_function);
>
> Shouldn't this use `kill-local-variable` instead or something like that?

Yup; now adjusted.

Eli Zaretskii <eliz@gnu.org> writes:

> I'm also not sure it is wise not to use nil here, since
> buffer-stale--default-function is only defined when files.el is
> loaded, so this could cause trouble during bootstrap (if not now, then
> in some distant future).  At least Ffboundp test is in order, I think.

nil is documented to be a legacy value, so it shouldn't be used.

Eli Zaretskii <eliz@gnu.org> writes:

> Come to think of this: why do we test that the variable is
> buffer-local?  This is in make-indirect-buffer, where the buffer was
> not yet "released" into the world, so how come it could have this
> variable as buffer-local already?

clone_per_buffer_values copies the local variables from the base buffer.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no