emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master ac1d15e95c 1/2: ; * src/data.c (Fash): More precise doc strin


From: Eli Zaretskii
Subject: Re: master ac1d15e95c 1/2: ; * src/data.c (Fash): More precise doc string
Date: Tue, 19 Jul 2022 16:49:31 +0300

> branch: master
> commit ac1d15e95c88592325afebb3d82c8c74a27d2627
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
> 
>     ; * src/data.c (Fash): More precise doc string
> ---
>  src/data.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/data.c b/src/data.c
> index 568349ba83..b2fcdaebee 100644
> --- a/src/data.c
> +++ b/src/data.c
> @@ -3519,7 +3519,9 @@ representation.  */)
>  DEFUN ("ash", Fash, Sash, 2, 2, 0,
>         doc: /* Return VALUE with its bits shifted left by COUNT.
>  If COUNT is negative, shifting is actually to the right.
> -In this case, the sign bit is duplicated.  */)
> +The return value is always VALUE multiplied by 2 to the power of COUNT,
> +rounding down (towards negative infinity).
> +VALUE and COUNT must be integers.  */)
>    (Lisp_Object value, Lisp_Object count)

I'm afraid I find the modified doc string less self-explanatory wrt
what happens when VALUE is negative.  It might be more accurate, but
makes it harder to understand what happens in that case.

Can we do better here, please?

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]