[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: feature/jit-improved-type-punning 9d2a54bd8d: src/comp.c: Use libgcc
From: |
Po Lu |
Subject: |
Re: feature/jit-improved-type-punning 9d2a54bd8d: src/comp.c: Use libgccjit's bitcast API for type coercion, when available. |
Date: |
Wed, 28 Sep 2022 08:22:36 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Vibhav Pant <vibhavp@gmail.com> writes:
> branch: feature/jit-improved-type-punning
> commit 9d2a54bd8dac68b964649f7d04d04d9fa0096a62
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
> src/comp.c: Use libgccjit's bitcast API for type coercion, when available.
>
> +#ifdef LIBGCCJIT_HAVE_gcc_jit_context_new_bitcast
> + #define gcc_jit_context_new_bitcast fn_gcc_jit_context_new_bitcast
> +#endif
This is not how we write nested defines, IIRC. They should be written
like so:
#ifdef LIBGCCJIT_HAVE_gcc_jit_context_new_bitcast
# define gcc_jit_context_new_bitcast fn_gcc_jit_context_new_bitcast
#endif
BTW, I don't see any code that loads this function dynamically on MS
Windows. Isn't that needed?
> +#else /* !definedLIBGCCJIT_HAVE_gcc_jit_context_new_bitcast) */
Here, simply write:
#else /* !LIBGCCJIT_HAVE_gcc_jit_context_new_bitcast */
or better, no comment, since what the else corresponds to is at a glance
obvious.
- Re: feature/jit-improved-type-punning 9d2a54bd8d: src/comp.c: Use libgccjit's bitcast API for type coercion, when available.,
Po Lu <=