[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master updated (cd8d3f3379e -> 1b0348d9593)
From: |
Stefan Monnier |
Subject: |
Re: master updated (cd8d3f3379e -> 1b0348d9593) |
Date: |
Sun, 18 Jun 2023 14:28:00 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> It looks like this patch series has broken esh-util-tests.el. Try
>
> --8<---------------cut here---------------start------------->8---
> # make -C test esh-util-tests
> ...
> Test esh-util-test/eshell-stringify/list condition:
> (ert-test-failed
> ((should (equal (eshell-stringify ...) "((1 2)\n (3 . 4))")) :form
> (equal "((1 2) (3 . 4))" "((1 2)\n (3 . 4))") :value nil
> :explanation
> (arrays-of-different-length 15 16 "((1 2) (3 . 4))"
> "((1 2)\n (3 . 4))" first-mismatch-at 6)))
> FAILED 9/13 esh-util-test/eshell-stringify/list (0.000212 sec) at
> lisp/eshell/esh-util-tests.el:47
> --8<---------------cut here---------------end--------------->8---
I don't think it's a bug if the output of the pretty printer is
((1 2) (3 . 4))
rather than
((1 2)
(3 . 4))
so I think the esh-util-tests is just too strict: both output are valid,
as are various others such as
((1
2)
(3
. 4))
Not knowing what the test is indeed the check I'm not sure how it should
be fixed. Maybe replace all `[ \n]+` with SPC ?
Stefan