Re: master e2ee646b162: cl-defsubst: Use static scoping for args

[Michael Albinus]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

Hi,

> branch: master
> commit e2ee646b162b87e832c8032b9d90577bd21f21f8
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     cl-defsubst: Use static scoping for args
>
>     * lisp/emacs-lisp/cl-macs.el (cl--slet): New function, partly extracted
>     from `cl--slet*`.
>     (cl--slet*): Use it.
>     (cl--defsubst-expand): Use it to fix bug#47552.
>
>     * test/lisp/emacs-lisp/cl-macs-tests.el (cl-defstruct-dynbound-label):
>     New test.

This breaks the tests:

--8<---------------cut here---------------start------------->8---
# make -C test cl-macs-tests
make: Entering directory '/home/albinus/src/emacs/test'
make[1]: Entering directory '/home/albinus/src/emacs/test'
  ELC      lisp/emacs-lisp/cl-macs-tests.elc

In toplevel form:
lisp/emacs-lisp/cl-macs-tests.el:815:39: Warning: Lexical argument shadows the 
dynamic variable cl--test-a
lisp/emacs-lisp/cl-macs-tests.el:816:45: Error: symbol-value cannot use lexical 
var `cl--test-a'
make[1]: *** [Makefile:159: lisp/emacs-lisp/cl-macs-tests.elc] Error 1
make[1]: Leaving directory '/home/albinus/src/emacs/test'
make: *** [Makefile:247: lisp/emacs-lisp/cl-macs-tests] Error 2
make: Leaving directory '/home/albinus/src/emacs/test'
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.