[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position):
From: |
Juri Linkov |
Subject: |
Re: master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185). |
Date: |
Fri, 30 Jun 2023 20:51:18 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
>> * lisp/misc.el (duplicate-line-final-position): New defcustom
>> (bug#64185).
>>
>> * lisp/misc.el (duplicate-line): Use it.
>>
>> * test/lisp/misc-tests.el (misc--duplicate-line): Add tests for
>> duplicate-line-final-position.
>
> When running the tests with native compilation, there's an error:
>
> ELC+ELN lisp/misc-tests.elc
> In toplevel form:
> lisp/misc-tests.el:95:12: Warning: Unused lexical variable
> `duplicate-line-final-position'
> lisp/misc-tests.el:102:12: Warning: Unused lexical variable
> `duplicate-line-final-position'
> GEN lisp/misc-tests.log
> Running 7 tests (2023-06-29 18:20:46+0000, selector `(not (tag :unstable))')
> Mark set (rectangle mode)
> passed 1/7 misc--duplicate-dwim (3.970630 sec)
> Test misc--duplicate-line backtrace:
> signal(ert-test-failed (((should (equal (point) 12)) :form (equal 7
> ert-fail(((should (equal (point) 12)) :form (equal 7 12) :value nil
> #f(compiled-function () #<bytecode -0x4c32571230de989>)()
> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> ert-run-test(#s(ert-test :name misc--duplicate-line :documentation n
> ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
> ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
> ert-run-tests-batch((not (tag :unstable)))
> ert-run-tests-batch-and-exit((not (tag :unstable)))
> command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/misc-tests" "--eval"
> command-line()
> normal-top-level()
> Test misc--duplicate-line condition:
> (ert-test-failed
> ((should
> (equal
> (point)
> 12))
> :form
> (equal 7 12)
> :value nil :explanation
> (different-atoms
> (7 "#x7" "?\7")
> (12 "#xc" "?\f"))))
> FAILED 2/7 misc--duplicate-line (0.000560 sec) at lisp/misc-tests.el:83
> passed 3/7 misc-test-backward-to-word (0.000207 sec)
> passed 4/7 misc-test-copy-from-above-command (0.000132 sec)
> passed 5/7 misc-test-forward-to-word (0.000131 sec)
> passed 6/7 misc-test-upcase-char (0.000114 sec)
> passed 7/7 misc-test-zap-up-to-char (0.000278 sec)
> Ran 7 tests, 6 results as expected, 1 unexpected (2023-06-29 18:20:50+0000,
> 4.174909 sec)
> 1 unexpected results:
> FAILED misc--duplicate-line ((should (equal (point) 12)) :form (equal 7
> 12) :value nil :explanation (different-atoms (7 "#x7" "?") (12 "#xc" "?\f")))
>
> See for example <https://emba.gnu.org/emacs/emacs/-/jobs/69705>.
>
> Running the tests w/o native compilation don't show that error.
It should go away after updating autoloads.
I did `make autoloads`, and there is no error anymore.