Re: master 7cd8236d35c: Pacify --enable-gcc-warnings with emacs_fdopen

[Paul Eggert]

On 2023-08-07 18:07, Po Lu wrote:

> now I receive warnings during the automated daily build of
> the Android port:
>
> ../../emacs/src/xfaces.c: In function ‘Fx_load_color_file’:
> ../../emacs/src/xfaces.c:7007:7: warning: ‘emacs_fclose’ called on pointer 
> returned from a mismatched allocation function [-Wmismatched-dealloc]
>   7007 |       emacs_fclose (fp);
>        |       ^~~~~~~~~~~~~~~~~
> ../../emacs/src/xfaces.c:6984:8: note: returned from ‘emacs_fopen’
>   6984 |   fp = emacs_fopen (SSDATA (abspath), "r" FOPEN_TEXT);

I gave a shot at fixing that by installing the attached. It works for me 
on Fedora 38, but then again the old version worked too. If this doesn't 
work on Android, it might help to send the preprocessed output.

By the way, I see lisp.h includes stdio.h now. Would it make sense to 
create a new include file for use only by the parts of Emacs that need 
to deal with stdio streams? We could move some of the stuff out of 
lisp.h, which is bulging a bit at the seams nowadays.

0001-Fix-some-emacs_fopen-confusion.patch
Description: Text Data