[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-an
From: |
Stefan Monnier |
Subject: |
Re: master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-and-exit): Inhibit interaction |
Date: |
Mon, 14 Aug 2023 10:39:26 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
>> FWIW, I added it because I'm seeing tests (e.g. `file-tests.el`) hang in
>> `read-event` (apparently because a (cl-letf ((symbol-function ..)) ..)
>> rebinding is not taking effect :-( ) and I figured that batch tests
>> should indeed never need interaction.
>
> I agree, but some tests persist. For example, abbrev-tests uses
> ert-simulate-keys to 'interact' with Emacs.
> Other test do morally equivalent things, and it is indubitably useful to be
> able to test interactive features non-interactively in some way.
Oh, I think I see: `inhibit-interaction` is probably tested too early,
e.g. upon entry to `read-event` (which can return without user
interaction if there's enough `unread-command-events` and friends)
instead of upon entry to the actual code that waits for user input, so
it doesn't quite do what I thought it would.
Stefan