emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Regression test `cl-print-tests-ellipsis-string' fails after latest cl-p


From: Jens Schmidt
Subject: Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes
Date: Sat, 30 Sep 2023 11:20:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1

Seems commit 01229fe0096e936ea8f4fad0d64967671c4b1892 has
introduced a regression.  The following fixes it:


diff --git a/test/lisp/emacs-lisp/cl-print-tests.el 
b/test/lisp/emacs-lisp/cl-print-tests.el
index 3073a42e39d..3aac161b344 100644
--- a/test/lisp/emacs-lisp/cl-print-tests.el
+++ b/test/lisp/emacs-lisp/cl-print-tests.el
@@ -60,7 +60,8 @@ cl-print-tests-ellipsis-vector
 
 (ert-deftest cl-print-tests-ellipsis-string ()
   "Ellipsis expansion works in strings."
-  (let ((print-length 4)
+  (let ((cl-print-string-length 4)
+        (print-length 4)
         (print-level 3))
     (cl-print-tests-check-ellipsis-expansion
      "abcdefg" "\"abcd...\"" "efg")


But the fact that one has to bind `cl-print-string-length' *and*
`print-length' could indicate that the commit probably is not
"complete" yet.  In the sense that more occurrences of `print-length'
need to be modified in cl-print.el.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]