emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ELPA submission: plz-see


From: Augusto Stoffel
Subject: Re: ELPA submission: plz-see
Date: Tue, 31 Oct 2023 21:17:39 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Thanks for the comments!

On Tue, 31 Oct 2023 at 08:43, Philip Kaludercic wrote:

> +(eval-when-compile (require 'cl-lib))
>  (require 'json)

By the way, the latter is kind of a non-essential require, would you
rather write this near line 88?

(defcustom plz-see-content-type-alist
  `(...
    ("\\`application/json" . ,(lambda ()
                                (require 'json)
                                (declare-function 'json-pretty-print-buffer 
"json.el")
                                (json-pretty-print-buffer)
                                (js-json-mode)))
  ...))


> I agree, from what I see this is just an implementation detail.  Plz is
> a peculiar enough name as it is, it shouldn't be inherited by packages
> that depend on it.  Or is there any reason why the package couldn't also
> use url.el?

The packages is really closely tied to plz's API, which by the way is a
very nice one.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]