emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Scheme-mode: Add support for regular expression literal


From: Jakub T. Jankiewicz
Subject: Re: [PATCH] Scheme-mode: Add support for regular expression literal
Date: Thu, 28 Mar 2024 12:33:54 +0100

One note about original solution in .emacs file that I used. It doesn't
correctly handle #; it works only till the end of the line (it should comment
out whole S-Expression). I hope that the code that was proposed for the
scheme.el was tested and handle this correctly.

On Sun, 24 Mar 2024 13:33:19 +0900
"Toshi Umehara" <toshi@niceume.com> wrote:

> Thank you very much for reviewing the patch, Stefan.
> 
> The patch is updated.
> 
> - Subexpression 1 is now used for regular expression rule in
>   syntax-propertize-rules
> 
> - Unused arguments are removed from caller and callee of
>   scheme-syntax-propertize-regexp
>   
> - Changing the third argument of re-search-forward from t to 'move moves
>   the point to end if the search does not find closing slash, which is
>   ideal.
> 
> Attached patches are separated into three. The first one changes only
> regular expression part mentioned above. The second one is NEWS update.
> The third one removes unused arguments also for
> scheme-syntax-propertize-sexp-comment . Please use them as you want.
> 
> Also about copyright assignment, this is the first commitment to GNU,
> and I have filled out the form and have emailed it to assign@gnu.org .
> 
> Thanks
> 

--
Jakub T. Jankiewicz, Senior Front-End Developer
https://jcubic.pl/me
https://lips.js.org
https://koduj.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]