Re: [PATCH] Implement fast verisons of json-parse functions

[Eli Zaretskii]

> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Sun, 31 Mar 2024 16:51:34 +0200
> Cc: Géza Herman <geza.herman@gmail.com>, emacs-devel@gnu.org
> 
> 31 mars 2024 kl. 07.08 skrev Eli Zaretskii <eliz@gnu.org>:
> 
> > Well, it's "kind-of" wrong argument: a string with embedded null
> > bytes.  But I'm also interested to hear from Mattias on this (and from
> > anyone else who might have an opinion about the kind of error we
> > should signal in this case).
> 
> I don't think users care much about the exact error we produce as long as 
> it's reasonably descriptive. It's only when user might reasonably 
> discriminate between different errors programmatically that it really 
> matters. We certainly shouldn't have a special message for NULs.
> 
> I spent a slow morning speeding up the new JSON parser substantially by not 
> doing stupid work, and all UTF-8 decoding errors will now be 
> `json-utf8-decode-error` instead of `json-parse-error`. I think we can live 
> with that.

I'm okay with changing the errors we signal, but let's please document
in NEWS all the changes in this area.