emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MINI-PATCH: add how to turn auto-completion in test buffers off


From: Pedro Andres Aranda Gutierrez
Subject: Re: MINI-PATCH: add how to turn auto-completion in test buffers off
Date: Sun, 7 Apr 2024 08:32:14 +0200

Hi again,

Is there any conceptual difference between providing flyspell/ispell-mode and providing
auto-complete suggestions in text mode? I personally don't think so and would like a more
thorough discussion on this. That we want Emacs to have as many features as modern text processors
provide is something that I strongly support. That we want all these features to be activated by default in
text mode merits much more debate. And that we want some and some not is confusing...

My .002 cents, /PA

On Fri, 5 Apr 2024 at 17:02, Pedro Andres Aranda Gutierrez <paaguti@gmail.com> wrote:
Hi,

answers inline.

On Fri, 5 Apr 2024 at 14:42, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> Date: Fri, 5 Apr 2024 12:25:18 +0200
> Cc: emacs-devel@gnu.org
>
> so you mean something like the attached patch?

Almost, see below.

> diff --git a/doc/emacs/text.texi b/doc/emacs/text.texi
> index cb347d59948..f039c42d46c 100644
> --- a/doc/emacs/text.texi
> +++ b/doc/emacs/text.texi
> @@ -954,6 +954,11 @@ Text Mode
>    Entering Text mode runs the mode hook @code{text-mode-hook}
>  (@pxref{Major Modes}).

> +@vindex text-mode-ispell-word-completion
> +  Entering Text mode also activates auto-complete hints. If you find
> +that this is disturbing for you, set this variable to @code{nil} in
> +your Emacs initialization code.

This is using the wrong tone for describing the issue: it regards
completion hints in Text Mode as a nuisance in most cases.  If it were
such a nuisance, we ought to make it off by default.

I will always remember a friend of mine, who always asked me to disable 
auto-completion and hints in his word processor, because they distracted
him too much from his work and line of thought. And, once again, some
concentration deficits need these features to be disabled, so I don't see
this as negative, but reaching out to these communities.
 
Instead, the text should describe the completion hints feature from
the POV of its being useful, and then say that the variable
text-mode-ispell-word-completion controls it.

OK, anyhow, I will try to find another wording.

Also, @vindex generates no text in the formatted manual, so you need
to mention the variable in the text as well, otherwise "this variable"
will allude to something the text doesn't mention.

Finally, please leave two spaces between sentences, per our
conventions.

> --- a/lisp/textmodes/text-mode.el
> +++ b/lisp/textmodes/text-mode.el
> @@ -145,7 +145,10 @@ text-mode
>  You can thus get the full benefit of adaptive filling
>   (see the variable `adaptive-fill-mode').
>  \\{text-mode-map}
> -Turning on Text mode runs the normal hook `text-mode-hook'."
> +Turning on Text mode runs the normal hook `text-mode-hook'.
> +By default, `text-mode-hook' will enable completion at point with
> +candidates supplied by `ispell'. You can turn this off by
> +setting `text-mode-ispell-word-completion' to `nil'."

This part is okay (modulo the 2 spaces between sentences issue).

Thanks.

/PA
--
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet



--
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet


reply via email to

[Prev in Thread] Current Thread [Next in Thread]