Re: [PATCH] Completion preview common

[Eshel Yaron]

Hi,

Ergus <spacibba@aol.com> writes:

> Your idea sounds very sensible. But I don't want to add unneeded
> complexity to the package. To get a complete candidates list I prefer
> to rely on other tools like company or Corfu. And getting the first
> entry in my use case is not very useful.

The patch you proposed adds an option to show only the longest common
prefix instead of a whole candidate, but the whole candidate includes
the longest common prefix, and so ISTM that it provides strictly more
information.  That's why an option that makes Completion Preview mode
only show the longest common prefix strikes me as less useful than
letting you complete only up to that common prefix on demand, while
still previewing a full candidate.  If that doesn't fit your bill,
perhaps you can describe the use case with some more detail?

> Certainly we can add many other features, properties, bindings and
> colors, but every feature implies complexity I'll like to avoid
> (specially in a completion feature code). The current package is
> simple, with few bindings and a predictable behavior. Please keep
> that.
>
> I added this change because it didn't imply more than 10 extra lines
> of execution code (ignoring comments); otherwise I would prefer to
> live with it as is.

While I agree that brevity and simplicity are some of the nice
properties of this library, IMO providing useful features is far more
important then keeping the line count to a minimum.  So if there's a
strong use case that we don't currently support, I wouldn't mind adding
10, 100 or 1000 lines of code to accommodate that.


Best,

Eshel