emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 1601c5a518d: Gnus: Add back end for Atom feeds (nnatom)


From: Eric Abrahamsen
Subject: Re: master 1601c5a518d: Gnus: Add back end for Atom feeds (nnatom)
Date: Sun, 28 Apr 2024 16:53:25 -0700
User-agent: Gnus/5.13 (Gnus v5.13)

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> On 04/28/24 12:53 PM, Michael Albinus wrote:
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>> Hi,
>>
>>> branch: master
>>> commit 1601c5a518dfa208af4827c56cf9570f3b90e15d
>>> Author: Daniel Semyonov <daniel@dsemy.com>
>>> Commit: Eric Abrahamsen <eric@ericabrahamsen.net>
>>>
>>>     Gnus: Add back end for Atom feeds (nnatom)
>>>
>>>     * lisp/gnus/gnus.el (gnus-valid-select-methods): Add entry for nnatom.
>>>     * lisp/gnus/nnfeed.el: New file implementing an abstract web feed back
>>>     end.
>>>     * lisp/gnus/nnatom.el: New file implementing a back end for Atom feeds.
>>>     * doc/misc/gnus.texi (Browsing the Web, Back End Interface):
>>>     * etc/NEWS (Gnus): Document nnatom and nnfeed.
>>> ---
>>>  doc/misc/gnus.texi  |  77 ++++++
>>>  etc/NEWS            |  10 +
>>>  lisp/gnus/gnus.el   |   1 +
>>>  lisp/gnus/nnatom.el | 276 +++++++++++++++++++++
>>>  lisp/gnus/nnfeed.el | 683 
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  5 files changed, 1047 insertions(+)
>>
>> This fails the tests:
>>
>> # make -C test test-custom-opts
>
> Thanks, we were missing a "category" definition in the new option
> default, fixing now.

This is still failing the tests, and I can't see why, I suspect the
reason is in the "... ..." below:

Test check-for-wrong-custom-opts condition:
    (ert-test-failed
     ((should (null (cus-test-opts t))) :form
      (null ((gnus-valid-select-methods :type-error ... ...))) :value nil))
   FAILED  1/1  check-for-wrong-custom-opts (13.744560 sec) at 
misc/test-custom-opts.el:33

I've edited test-custom-opts.el to let-bind
`ert-batch-print-level/length' to nil around the (cus-test-opts t) call,
but that doesn't change anything -- can anyone tell me how to expand the
output there?

Thanks,
Eric




reply via email to

[Prev in Thread] Current Thread [Next in Thread]