Re: Add Tango and Adwaita icons for the toolbar

[Elijah G]

On Sun, May 5, 2024 at 11:32 PM Yuan Fu <casouri@gmail.com> wrote:
>
>
>
> > On May 5, 2024, at 10:10 PM, Elijah G <eg642616@gmail.com> wrote:
> >
> > El dom., 5 de mayo de 2024 12:57 a. m., Yuan Fu <casouri@gmail.com> 
> > escribió:
> >
> >
> > > On May 4, 2024, at 9:07 PM, Elijah G <eg642616@gmail.com> wrote:
> > >
> > > Yuan Fu <casouri@gmail.com> writes:
> > > > I certainly would like to have xpm and bpm versions for the new
> > > > icons, but as I said, I’m no graphic designer and have no ability to 
> > > > hand-draw
> > > > them; the only thing I can do is to convert them from png, which you 
> > > > also
> > > > against. (Though, to be fair, even if I have the
> > > > ability, I probably wouldn’t want to, it’s a lot of work to hand draw 
> > > > all these icons.)
> > >
> > > Hi, I'm interested in help to convert the icons into xpm and bpm, i think 
> > > the process would be faster if the original icons are in svg otherwise i 
> > > can make my best effort in help.
> >
> > That’s great news! You can find the svg icons I made in etc/images/scalable 
> > in the scratch/tango-icons branch. You can get that branch by
> >
> > git clone -b scratch/tango-icons git://git.sv.gnu.org/emacs.git
> >
> > That branch is modified to load the png icons in etc/images for the 
> > tool-bar (assuming you’re using a mac, on Linux Emacs will use the system 
> > icons).
> >
> > If you’d like to, feel free to improve the svg icons I made too. I also 
> > attached the svg tango and adwaita icons that I used, in case they’ll be 
> > useful.
> >
> > Thank you, i have a question, should i send a patch to this thread when i 
> > have the icons?
>
> Sending large files on the mailing list doesn’t seem like a good idea, maybe 
> we can collaborate on GitHub/sourcehut? Let me know which one you’d prefer, 
> or if you have better ideas.

I prefer using GitHub since I don't know how to use sourcehut,
i've created a repo where its stored the icons that i made + patch file,

https://github.com/DevelopmentCool2449/emacs/tree/scratch/tango-icons

Patch file: 
https://raw.githubusercontent.com/DevelopmentCool2449/emacs/scratch/tango-icons/PATCH-0001-Convert-and-change-tango-icons-to-xpm-and-pbm.patch

Currently i only completed some icons, i will try to complete the remain
the next days.

But in short, the xpm and pbm are a little different from the originals,
(i had to make ones by hand), i've recolored the close.* icons to a red-ish one.
Now i've added 1 hand to index.* icons (it may be a bit ugly since i
find hard drawing hands)

if anyone have any commentary, i would gladly listen them.