[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 0023891e842: Support hints in the :repeat keyword of defvar-k
From: |
Eshel Yaron |
Subject: |
Re: master 0023891e842: Support hints in the :repeat keyword of defvar-keymap for repeat-mode |
Date: |
Wed, 08 May 2024 18:40:01 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Juri Linkov <juri@linkov.net> writes:
>>>>> Lastly, it could be nice to make the appearance of the prompt more in
>>>>> line with the read-multiple-choice prompt, which is conceptually very
>>>>> similar. Crucially, if the key is a character that occurs in the label,
>>>>> it's better, IMO, to highlight the first occurrence of that character in
>>>>> the label (as r-m-c does) than to prefix the label with that character.
>>>>> We can reuse rmc--add-key-description for that purpose, as follows:
>>>>
>>>> Nice idea. A small problem is that when hints are not used,
>>>> it inserts an extra space between the character and comma.
>>
>> Well spotted. How about something like the diff below?
>
> This looks better, thanks.
Great, pushed to master (commit 840c33070dc).