Re: master 74bb1e5897f 2/3: Fix filling in c-ts-mode (bug#72116)

[Yuan Fu]

> On Aug 3, 2024, at 12:30 AM, Yuan Fu <casouri@gmail.com> wrote:
> 
> 
> 
>> On Aug 1, 2024, at 1:53 AM, Andrea Corallo <acorallo@gnu.org> wrote:
>> 
>> Yuan Fu <casouri@gmail.com> writes:
>> 
>>> branch: master
>>> commit 74bb1e5897f4532fbdefddada28258a8d3d5c95f
>>> Author: Yuan Fu <casouri@gmail.com>
>>> Commit: Yuan Fu <casouri@gmail.com>
>>> 
>>>   Fix filling in c-ts-mode (bug#72116)
>>> 
>>>   The previous fix introduced a regression in the case when there's only a
>>>   single line in the block comment.  In that case we don't want to add a
>>>   start at the second line:
>>> 
>>>   /* foo foo foo */ should => /* foo foo
>>>                                  foo */
>>> 
>>>   rather than   /* foo foo
>>>                  * foo */
>>> 
>>>   This commit fixes that.
>>> 
>>>   * lisp/progmodes/c-ts-common.el:
>>>   (c-ts-common--fill-block-comment): Don't mask the /*.
>>>   (c-ts-common--adaptive-fill-prefix): New function.
>>>   (c-ts-common-comment-setup): Don't set adaptive-regexp, change
>>>   adaptive-fill-first-line-regexp to work with the new
>>>   adaptive-fill-function.
>>>   * test/lisp/progmodes/c-ts-mode-resources/filling.erts: New tests
>> 
>> Hi Yuan,
>> 
>> this change is causing the following regression on my testbench on
>> master:
>> 
>> c-ts-mode-test-filling
>> 1/4  c-ts-mode-test-filling (0.015896 sec) at 
>> lisp/progmodes/c-ts-mode-tests.el:38
>> 
>> Would you mind having a look?
>> 
>> Thanks
> 
> Yes absolutely, wonder why it didn’t error when I wrote the patch :-(

Ok, should be fixed now.

Yuan