[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 8c81818673a 6/7: Tune volatile in read_char
From: |
Eli Zaretskii |
Subject: |
Re: master 8c81818673a 6/7: Tune volatile in read_char |
Date: |
Mon, 19 Aug 2024 22:29:07 +0300 |
> Date: Mon, 19 Aug 2024 19:05:12 +0000
> From: Pip Cet <pipcet@protonmail.com>
> Cc: acorallo@gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org,
> stefankangas@gmail.com
>
> "Eli Zaretskii" <eliz@gnu.org> writes:
>
> >> either duplicating them into a 'c_volatile'
> >> / 'c' pair, as Paul's patch did, or keeping a single volatile
> >> variable. I think "let's make all of them volatile" is an obvious
> >> simplification of that idea.
> >
> > Why not simply undo that single patch, and be done?
>
> Because we will run into further setjmp()-related bugs.
What bugs? that change is described as a minor optimization, so no
bugs should be caused by reverting it.
- Re: master 8c81818673a 6/7: Tune volatile in read_char, (continued)
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Paul Eggert, 2024/08/18
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Andrea Corallo, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Eli Zaretskii, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Pip Cet, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Eli Zaretskii, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Pip Cet, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Eli Zaretskii, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Paul Eggert, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Eli Zaretskii, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Pip Cet, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char,
Eli Zaretskii <=
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Paul Eggert, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Pip Cet, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Paul Eggert, 2024/08/19
- Re: master 8c81818673a 6/7: Tune volatile in read_char, Pip Cet, 2024/08/19