emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reconsider defaults for use-package-vc-prefer-newest


From: Eli Zaretskii
Subject: Re: Reconsider defaults for use-package-vc-prefer-newest
Date: Sun, 29 Sep 2024 17:35:42 +0300

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 29 Sep 2024 07:22:10 -0700
> Cc: suhailsingh247@gmail.com, emacs-devel@gnu.org, philipk@posteo.net, 
>       meedstrom@runbox.eu, tonyzorman@mailbox.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > The above seems to indicate there's some kind of bug in deciding
> > whether there's a commit mismatch, because I don't see anything wrong
> > with what you do.
> 
> The problem is the order in which the steps are taken.  A git tag should
> be added only to those commits that bump the "Version" header, or you
> will run into problems.
> 
> In other words, this:
> 
>   1. Create a feature branch from the `main` branch.
>   2. Bump the `Version:` header.
>   3. Make commits to the feature branch.
>   4. Merge the feature branch back to `main`.
>   5. Tag `main` with the `Version:` header value.

In the original description, step 2 and step 3 were in reverse order,
AFAIR, or at least I thought so.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]