Re: [PATCH] configure.ac: Fix FIONREAD check to work with gcc-14 on Solaris

[Sam James]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Sam James <sam@gentoo.org>
>> Cc: Stefan Kangas <stefankangas@gmail.com>,  alan.coopersmith@oracle.com,
>>   emacs-devel@gnu.org,  Ali.Bahrami@oracle.com
>> Date: Wed, 23 Oct 2024 15:56:33 +0100
>> 
>> >> I guess this should be installed on emacs-30.  Eli, WDYT?
>> >
>> > I'd prefer on master.  Who knows what addition of unistd.h could cause
>> > to this test?
>> 
>> Note that the absence of the include means the configure check gives the
>> wrong result, it doesn't mean Emacs necessarily fails to build as a
>> result. It may be built with the wrong configuration.
>
> I understand.  But Solaris isn't a very important platform for us to
> risk screwing other platforms, when we are quite close to a release,
> and people who want to build Emacs 30 on Solaris can always apply this
> change by hand.

OK, fair enough.