Re: New "make benchmark" target

[Pip Cet]

"Eli Zaretskii" <eliz@gnu.org> writes:

>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Mon, 30 Dec 2024 23:26:05 -0600
>> Cc: acorallo@gnu.org, mattiase@acm.org, eggert@cs.ucla.edu,
>>      emacs-devel@gnu.org
>>
>> I'd put this in a directory named "benchmarks" instead.
>
> I think this name is indeed better.

Is this about the directory or the make target?  Absolutely no
objections on the directory name, as it won't conflict with putting new
ERT-based benchmarks in test/.

As for the make target, we should decide whether "make benchmark" means
"run all benchmarks no matter which framework" or "run the
elisp-benchmarks specifically".  I don't think

benchmark: elisp-benchmarks check-benchmark

is a bad rule at all.

Pip