[Emacs-diffs] /srv/bzr/emacs/trunk r100032: tool-bar.el: Revert unintended checkin in rev 100010.

[Jan D]

------------------------------------------------------------
revno: 100032
committer: Jan D <address@hidden>
branch nick: trunk
timestamp: Sun 2010-04-25 09:23:01 +0200
message:
  tool-bar.el: Revert unintended checkin in rev 100010.
modified:
  lisp/ChangeLog
  lisp/tool-bar.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2010-04-24 02:36:43 +0000
+++ b/lisp/ChangeLog    2010-04-25 07:23:01 +0000
@@ -1,3 +1,8 @@
+2010-04-25  Jan Djärv  <address@hidden>
+
+       * tool-bar.el (tool-bar-local-item-from-menu): Revert unintended
+       checkin in rev 100010.
+
 2010-04-24  Glenn Morris  <address@hidden>
 
        * emacs-lisp/authors.el (authors-obsolete-files-regexps):

=== modified file 'lisp/tool-bar.el'
--- a/lisp/tool-bar.el  2010-04-23 16:26:11 +0000
+++ b/lisp/tool-bar.el  2010-04-25 07:23:01 +0000
@@ -243,24 +243,24 @@
                 ;; Last element in the bound key sequence:
                 (kk (aref k (1- (length k)))))
             (if (and (keymapp m)
-                     (symbolp kk))      ;FIXME: Why?  --Stef
+                     (symbolp kk))
                 (setq submap m
                       key kk)))))
-    (when submap
-      (let ((defn nil))
-        ;; Here, we're essentially doing a "lookup-key without get_keyelt".
-        (map-keymap (lambda (k b) (if (eq k key) (setq defn b)))
-                    submap)
+    (when (and (symbolp submap) (boundp submap))
+      (setq submap (eval submap)))
+    (let ((defn (assq key (cdr submap))))
+      (if (eq (cadr defn) 'menu-item)
+          (define-key-after in-map (vector key)
+            (append (cdr defn) (list :image image-exp) props))
+        (setq defn (cdr defn))
         (define-key-after in-map (vector key)
-          (if (eq (car defn) 'menu-item)
-              (append (cdr defn) (list :image image-exp) props)
-            (let ((rest (cdr defn)))
-              ;; If the rest of the definition starts
-              ;; with a list of menu cache info, get rid of that.
-              (if (and (consp rest) (consp (car rest)))
-                  (setq rest (cdr rest)))
-              (append `(menu-item ,(car defn) ,rest)
-                      (list :image image-exp) props))))))))
+          (let ((rest (cdr defn)))
+            ;; If the rest of the definition starts
+            ;; with a list of menu cache info, get rid of that.
+            (if (and (consp rest) (consp (car rest)))
+                (setq rest (cdr rest)))
+            (append `(menu-item ,(car defn) ,rest)
+                    (list :image image-exp) props)))))))
 
 ;;; Set up some global items.  Additions/deletions up for grabs.