[Emacs-diffs] /srv/bzr/emacs/emacs-23 r100374: * message.el (message-mail): A compose-mail function should accept headers as strings.

[Glenn Morris]

------------------------------------------------------------
revno: 100374
committer: Glenn Morris <address@hidden>
branch nick: emacs-23
timestamp: Tue 2011-01-11 19:53:28 -0800
message:
  * message.el (message-mail): A compose-mail function should accept headers as 
strings.
modified:
  lisp/gnus/ChangeLog
  lisp/gnus/message.el

=== modified file 'lisp/gnus/ChangeLog'
--- a/lisp/gnus/ChangeLog       2011-01-02 23:50:46 +0000
+++ b/lisp/gnus/ChangeLog       2011-01-12 03:53:28 +0000
@@ -1,3 +1,8 @@
+2011-01-12  Glenn Morris  <address@hidden>
+
+       * message.el (message-mail): A compose-mail function should
+       accept headers as strings.
+
 2010-11-19  Yuri Karaban  <address@hidden>  (tiny change)
 
        * pop3.el (pop3-open-server): Read server greeting before starting TLS
@@ -13920,4 +13925,3 @@
 ;; add-log-time-zone-rule: t
 ;; End:
 
-;;; arch-tag: 3f33a3e7-090d-492b-bedd-02a1417d32b4

=== modified file 'lisp/gnus/message.el'
--- a/lisp/gnus/message.el      2011-01-02 23:50:46 +0000
+++ b/lisp/gnus/message.el      2011-01-12 03:53:28 +0000
@@ -6493,7 +6493,13 @@
     (message-setup
      (nconc
       `((To . ,(or to "")) (Subject . ,(or subject "")))
-      (when other-headers other-headers))
+      ;; C-h f compose-mail says that headers should be specified as
+      ;; (string . value); however all the rest of message expects
+      ;; headers to be symbols, not strings (eg message-header-format-alist).
+      ;; http://lists.gnu.org/archive/html/emacs-devel/2011-01/msg00337.html
+      ;; We need to convert any string input, eg from rmail-start-mail.
+      (dolist (h other-headers other-headers)
+       (if (stringp (car h)) (setcar h (intern (capitalize (car h)))))))
      yank-action send-actions continue switch-function)
     ;; FIXME: Should return nil if failure.
     t))
@@ -8195,5 +8201,4 @@
 ;; coding: iso-8859-1
 ;; End:
 
-;; arch-tag: 94b32cac-4504-4b6c-8181-030ebf380ee0
 ;;; message.el ends here