Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107024: Small define-minor-mode fix for variable: keyword.

[Stefan Monnier]

>       (:keymap (setq keymap (pop body)))
>          (:variable (setq variable (pop body))
> -         (if (not (functionp (cdr-safe variable)))
> +         (setq tmp (cdr-safe variable))
> +         (if (not (or (functionp tmp)
> +                      (and tmp
> +                           (symbolp tmp)
> +                           ;; Hack to allow for named functions not within
> +                           ;; eval-when-compile.
> +                           ;; Cf define-compilation-mode.
> +                           (boundp 'byte-compile-function-environment)
> +                           (assq tmp byte-compile-function-environment))))

It's probably sufficient to check (and (cdr-safe variable)
                                       (or (symbolp (cdr variable))
                                           (functionp (cdr variable))))

so as to avoid the byte-compile-function-environment hack.


        Stefan