[Emacs-diffs] /srv/bzr/emacs/trunk r107636: * lisp/wid-edit.el (widget-complete-field): Remove.

[Stefan Monnier]

------------------------------------------------------------
revno: 107636
fixes bug(s): http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11051
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Tue 2012-03-20 22:13:52 -0400
message:
  * lisp/wid-edit.el (widget-complete-field): Remove.
  (widget-complete): Remove broken use of it.
modified:
  lisp/ChangeLog
  lisp/wid-edit.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-03-20 15:44:45 +0000
+++ b/lisp/ChangeLog    2012-03-21 02:13:52 +0000
@@ -1,7 +1,12 @@
+2012-03-21  Stefan Monnier  <address@hidden>
+
+       * wid-edit.el (widget-complete-field): Remove (bug#11051).
+       (widget-complete): Remove broken use of it.
+
 2012-03-20  Chong Yidong  <address@hidden>
 
-       * emacs-lisp/tabulated-list.el (tabulated-list-print-entry): Use
-       string-width and truncate-string-width to handle arbitrary
+       * emacs-lisp/tabulated-list.el (tabulated-list-print-entry):
+       Use string-width and truncate-string-width to handle arbitrary
        characters.
 
 2012-03-20  Tassilo Horn  <address@hidden>
@@ -17,8 +22,7 @@
 
 2012-03-18  Leo Liu  <address@hidden>
 
-       * net/rcirc.el (rcirc-cmd-quit): Allow quiting all servers with
-       prefix.
+       * net/rcirc.el (rcirc-cmd-quit): Allow quiting all servers with prefix.
 
 2012-03-17  Eli Zaretskii  <address@hidden>
 
@@ -48,7 +52,7 @@
        (hfy-fontify-buffer): Use above handlers.
        (hfy-face-to-css-default): Same as the earlier `hfy-face-to-css'.
        (hfy-face-to-css): Re-defined to be a variable.
-       (hfy-compile-stylesheet): Modified.  Allow stylesheet to be built
+       (hfy-compile-stylesheet): Modify.  Allow stylesheet to be built
        over multiple runs. This is made possible by having the caller let
        bind a special variable `hfy-user-sheet-assoc'.
        (htmlfontify-string): New defun.
@@ -72,10 +76,8 @@
        * progmodes/cc-engine.el (c-crosses-statement-barrier-p): Use a
        limit to a call of `c-literal-limits'.
        (c-determine-+ve-limit): New function.
-       (c-at-macro-vsemi-p): Move `c-in-literal' to the bottom of an
-       `and'.
-       (c-guess-basic-syntax): In macros, restrict a search limit to
-       2000.
+       (c-at-macro-vsemi-p): Move `c-in-literal' to the bottom of an `and'.
+       (c-guess-basic-syntax): In macros, restrict a search limit to 2000.
        In CASE 5B, restrict a search limit to 500.
        (c-just-after-func-arglist-p): Obviouly wrong `or' -> `and'.
 
@@ -89,7 +91,7 @@
 2012-03-16  Aaron S. Hawley  <address@hidden>
 
        * tar-mode.el (tar-mode): Fix saving by conditionally undoing
-        `special-mode' setting of `buffer-read-only'.  (Bug#11010)
+       `special-mode' setting of `buffer-read-only'.  (Bug#11010)
 
 2012-03-16  Glenn Morris  <address@hidden>
 
@@ -156,8 +158,7 @@
 
 2012-03-12  Leo Liu  <address@hidden>
 
-       * simple.el (kill-new): Use equal-including-properties for
-       comparison.
+       * simple.el (kill-new): Use equal-including-properties for comparison.
        (kill-do-not-save-duplicates): Doc fix.
 
 2012-03-12  Stefan Monnier  <address@hidden>
@@ -239,8 +240,7 @@
 
        * net/mairix.el (mairix-replace-invalid-chars): Rename from
        mairix-replace-illegal-chars; all callers changed.  Don't remove
-       ^, ~, and = characters: they are meaningful in mairix search
-       specs.
+       ^, ~, and = characters: they are meaningful in mairix search specs.
        (mairix-widget-create-query): Add usage information about mairix
        search forms: negating words, searching for substrings, etc.
 
@@ -425,8 +425,7 @@
 
 2012-03-04  Chong Yidong  <address@hidden>
 
-       * cus-start.el: Make x-select-enable-clipboard-manager
-       customizable.
+       * cus-start.el: Make x-select-enable-clipboard-manager customizable.
 
 2012-03-04  Glenn Morris  <address@hidden>
 
@@ -557,7 +556,7 @@
        (font-lock-default-function): Move the check for a specification
        to font-lock-spec-present.
 
-       * font-lock.el (font-lock-initial-fontify): call ...
+       * font-lock.el (font-lock-initial-fontify): Call ...
        (font-lock-spec-present): New function.
 
 2012-02-26  Jim Blandy  <address@hidden>
@@ -886,8 +885,7 @@
 
 2012-02-12  Teodor Zlatanov  <address@hidden>
 
-       * net/gnutls.el (gnutls-algorithm-priority): Add missing :group
-       tag.
+       * net/gnutls.el (gnutls-algorithm-priority): Add missing :group tag.
 
 2012-02-12  Alan Mackenzie  <address@hidden>
 
@@ -1060,8 +1058,8 @@
        * progmodes/cc-guess.el (c-guess-offset-threshold, c-guess-region-max):
        Add :version tags.
 
-       * progmodes/compile.el (compilation-first-column)
-       (compilation-error-screen-columns, compilation-filter-start): Doc fixes.
+       * progmodes/compile.el (compilation-error-screen-columns)
+       (compilation-first-column, compilation-filter-start): Doc fixes.
 
        * vc/log-view.el (log-view-toggle-entry-display):
        * vc/vc.el (vc-merge, vc-pull): Doc fixes.

=== modified file 'lisp/wid-edit.el'
--- a/lisp/wid-edit.el  2012-02-05 15:33:30 +0000
+++ b/lisp/wid-edit.el  2012-03-21 02:13:52 +0000
@@ -1141,12 +1141,6 @@
        (kill-region (point) end)
       (call-interactively 'kill-line))))
 
-(defcustom widget-complete-field (lookup-key global-map "\M-\t")
-  "Default function to call for completion inside fields."
-  :options '(ispell-complete-word complete-tag lisp-complete-symbol)
-  :type 'function
-  :group 'widgets)
-
 (defun widget-narrow-to-field ()
   "Narrow to field."
   (interactive)
@@ -1169,10 +1163,6 @@
         (completion-in-region (nth 0 data) (nth 1 data) (nth 2 data)
                               (plist-get completion-extra-properties
                                          :predicate))))
-     ((widget-field-find (point))
-      ;; This defaulting used to be performed in widget-default-complete, but
-      ;; it seems more appropriate here than in widget-default-completions.
-      (call-interactively 'widget-complete-field))
      (t
       (error "Not in an editable field")))))
 ;; We may want to use widget completion in buffers where the major mode