[Emacs-diffs] /srv/bzr/emacs/trunk r109148: * src/eval.c (Fdefvar): Don't check constants since we only set the var if

[Stefan Monnier]

------------------------------------------------------------
revno: 109148
fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11904
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Wed 2012-07-18 11:20:33 -0400
message:
  * src/eval.c (Fdefvar): Don't check constants since we only set the var if
  it's not yet defined anyway.
modified:
  src/ChangeLog
  src/eval.c

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2012-07-18 13:20:59 +0000
+++ b/src/ChangeLog     2012-07-18 15:20:33 +0000
@@ -1,5 +1,8 @@
 2012-07-18  Stefan Monnier  <address@hidden>
 
+       * eval.c (Fdefvar): Don't check constants since we only set the var if
+       it's not yet defined anyway (bug#11904).
+
        * lisp.h (last_undo_boundary): Declare new var.
        * keyboard.c (command_loop_1): Set it.
        * cmds.c (Fself_insert_command): Use it to only remove boundaries that

=== modified file 'src/eval.c'
--- a/src/eval.c        2012-07-10 16:53:26 +0000
+++ b/src/eval.c        2012-07-18 15:20:33 +0000
@@ -691,18 +691,6 @@
       /* Do it before evaluating the initial value, for self-references.  */
       XSYMBOL (sym)->declared_special = 1;
 
-      if (SYMBOL_CONSTANT_P (sym))
-       {
-         /* For upward compatibility, allow (defvar :foo (quote :foo)).  */
-         Lisp_Object tem1 = Fcar (tail);
-         if (! (CONSP (tem1)
-                && EQ (XCAR (tem1), Qquote)
-                && CONSP (XCDR (tem1))
-                && EQ (XCAR (XCDR (tem1)), sym)))
-           error ("Constant symbol `%s' specified in defvar",
-                  SDATA (SYMBOL_NAME (sym)));
-       }
-
       if (NILP (tem))
        Fset_default (sym, eval_sub (Fcar (tail)));
       else