|
From: | Stefan Monnier |
Subject: | Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109810: * eshell/esh-ext.el (eshell-external-command): Do not examine |
Date: | Wed, 29 Aug 2012 13:30:59 -0400 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) |
> + (let ((interp (eshell-find-interpreter > + command > + ;; Do not examine remote shell scripts. > + (or (and (stringp command) (file-remote-p command)) > + (file-remote-p default-directory))))) I think that most uses of file-remote-p are wrong (in the sense that, while they may return an info that's correlated with the one we need, it's not exactly what we need) and this one is no exception. So I think in the above case it'd be better to use something along the lines of `ignore-errors'. Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |