[Emacs-diffs] trunk r114958: Get rid of --chdir usage in test/automated

[Glenn Morris]

------------------------------------------------------------
revno: 114958
revision-id: address@hidden
parent: address@hidden
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Mon 2013-11-04 21:58:40 -0500
message:
  Get rid of --chdir usage in test/automated
  
  * test/automated/Makefile.in (EMACSOPT): Move -L here.
  (emacs): Set EMACS_TEST_DIRECTORY in the environment.
  (setwins): Don't assume called from srcdir.  Remove legacy stuff.
  (.el.elc): No more need to pass -L here.
  (compile-main): Get rid of sub-shell and cd.
  (compile-clean, check): Get rid of cd.
modified:
  test/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-8588
  test/automated/Makefile.in     makefile.in-20110112160650-056hnl9qhpjvjicy-6

=== modified file 'test/ChangeLog'
--- a/test/ChangeLog    2013-11-05 02:54:38 +0000
+++ b/test/ChangeLog    2013-11-05 02:58:40 +0000
@@ -1,5 +1,13 @@
 2013-11-05  Glenn Morris  <address@hidden>
 
+       Get rid of --chdir usage.
+       * automated/Makefile.in (EMACSOPT): Move -L here.
+       (emacs): Set EMACS_TEST_DIRECTORY in the environment.
+       (setwins): Don't assume called from srcdir.  Remove legacy stuff.
+       (.el.elc): No more need to pass -L here.
+       (compile-main): Get rid of sub-shell and cd.
+       (compile-clean, check): Get rid of cd.
+
        Make it possible to run tests with a different working directory.
        * automated/flymake-tests.el (flymake-tests-data-directory): New.
        (flymake-tests--current-face): Use flymake-tests-data-directory.

=== modified file 'test/automated/Makefile.in'
--- a/test/automated/Makefile.in        2013-11-04 01:48:08 +0000
+++ b/test/automated/Makefile.in        2013-11-05 02:58:40 +0000
@@ -28,19 +28,20 @@
 EMACS = ../../src/emacs
 
 # Command line flags for Emacs.
-EMACSOPT = -batch --no-site-file --no-site-lisp
+EMACSOPT = -batch --no-site-file --no-site-lisp -L :$(srcdir)
 
 # Extra flags to pass to the byte compiler.
 BYTE_COMPILE_EXTRA_FLAGS =
 
 # The actual Emacs command run in the targets below.
 # Prevent any setting of EMACSLOADPATH in user environment causing problems.
-emacs = unset EMACSLOADPATH; LC_ALL=C "$(EMACS)" $(EMACSOPT)
+emacs = unset EMACSLOADPATH; \
+       LC_ALL=C EMACS_TEST_DIRECTORY=$(srcdir) "$(EMACS)" $(EMACSOPT)
 
 # Common command to find subdirectories
-setwins=subdirs=`find . -type d -print`; \
+setwins=subdirs=`find $(srcdir) -type d -print`; \
        for file in $$subdirs; do \
-          case $$file in */.* | */.*/* | */=* | ./data* ) ;; \
+          case $$file in */data* | */flymake* ) ;; \
                *) wins="$$wins$${wins:+ }$$file" ;; \
           esac; \
         done
@@ -55,7 +56,7 @@
 
 .el.elc:
        @echo Compiling $<
-       @$(emacs) -L :$(srcdir) $(BYTE_COMPILE_EXTRA_FLAGS) -f 
batch-byte-compile $<
+       @$(emacs) $(BYTE_COMPILE_EXTRA_FLAGS) -f batch-byte-compile $<
 
 
 .PHONY: compile-targets compile-main compile-clean
@@ -66,20 +67,20 @@
 # Compile all the Elisp files that need it.  Beware: it approximates
 # `no-byte-compile', so watch out for false-positives!
 compile-main: compile-clean
-       @(cd $(srcdir) && $(setwins); \
+       @$(setwins); \
        els=`echo "$$wins " | sed -e 's|/\./|/|g' -e 's|/\. | |g' -e 's| |/*.el 
|g'`; \
        for el in $$els; do \
          test -f $$el || continue; \
          test ! -f $${el}c && GREP_OPTIONS= grep '^;.*no-byte-compile: t' $$el 
> /dev/null && continue; \
          echo "$${el}c"; \
-       done | xargs echo) | \
+       done | xargs echo | \
        while read chunk; do \
          $(MAKE) $(MFLAGS) compile-targets EMACS="$(EMACS)" TARGETS="$$chunk"; 
\
        done
 
 # Erase left-over .elc files that do not have a corresponding .el file.
 compile-clean:
-       @cd $(srcdir) && $(setwins); \
+       @$(setwins); \
        elcs=`echo "$$wins " | sed -e 's|/\./|/|g' -e 's|/\. | |g' -e 's| 
|/*.elc |g'`; \
        for el in $$(echo $$elcs | sed -e 's/\.elc/\.el/g'); do \
          if test -f "$$el" -o \! -f "$${el}c"; then :; else \
@@ -101,7 +102,7 @@
 
 
 check: compile-main
-       @thisdir=`pwd`; cd $(srcdir) && $(setwins); \
+       @$(setwins); \
        pattern=`echo "$$wins " | sed -e 's|/\./|/|g' -e 's|/\. | |g' -e 's| 
|/*.el |g'`; \
        for el in $$pattern; do \
          test -f $$el || continue; \
@@ -109,7 +110,6 @@
          els="$$els $$el"; \
        done; \
        echo Testing $$els; \
-       cd "$$thisdir"; \
-       $(emacs) --chdir $(srcdir) -L :. $$args -f ert-run-tests-batch-and-exit
+       $(emacs) $$args -f ert-run-tests-batch-and-exit
 
 # Makefile ends here.