emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master aca6082 1/2: Suppress filenotify remote test failur


From: Glenn Morris
Subject: [Emacs-diffs] master aca6082 1/2: Suppress filenotify remote test failures on hydra.nixos.org
Date: Sat, 15 Dec 2018 18:17:03 -0500 (EST)

branch: master
commit aca60820e16560cc84fe9e093030262f6c4cbd59
Author: Glenn Morris <address@hidden>
Commit: Glenn Morris <address@hidden>

    Suppress filenotify remote test failures on hydra.nixos.org
    
    * test/lisp/filenotify-tests.el (file-notify--deftest-remote):
    Add optional argument to pass expected-result.
    (file-notify-test04-autorevert-remote)
    (file-notify-test08-backup-remote): Expect failure on hydra (bug#33735).
---
 test/lisp/filenotify-tests.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el
index 612ea8c..26b8276 100644
--- a/test/lisp/filenotify-tests.el
+++ b/test/lisp/filenotify-tests.el
@@ -240,12 +240,13 @@ This returns only for the local case and gfilenotify; 
otherwise it is nil.
                              (gfile-monitor-name file-notify--test-desc)))
           (cdr (assq file-notify--test-desc file-notify--test-monitors))))))
 
-(defmacro file-notify--deftest-remote (test docstring)
+(defmacro file-notify--deftest-remote (test docstring &optional expected)
   "Define ert `TEST-remote' for remote files."
   (declare (indent 1))
   `(ert-deftest ,(intern (concat (symbol-name test) "-remote")) ()
      ,docstring
      :tags '(:expensive-test)
+     :expected-result (or ,expected :passed)
      (let* ((temporary-file-directory
             file-notify-test-remote-temporary-file-directory)
            (ert-test (ert-get-test ',test)))
@@ -917,7 +918,8 @@ delivered."
       (file-notify--test-cleanup))))
 
 (file-notify--deftest-remote file-notify-test04-autorevert
-  "Check autorevert via file notification for remote files.")
+  "Check autorevert via file notification for remote files."
+  (if (getenv "EMACS_HYDRA_CI") :failed :passed)) ; fixme bug#33735
 
 (ert-deftest file-notify-test05-file-validity ()
   "Check `file-notify-valid-p' for files."
@@ -1239,7 +1241,8 @@ delivered."
     (file-notify--test-cleanup)))
 
 (file-notify--deftest-remote file-notify-test08-backup
-  "Check that backup keeps file notification for remote files.")
+  "Check that backup keeps file notification for remote files."
+  (if (getenv "EMACS_HYDRA_CI") :failed :passed)) ; fixme bug#33735
 
 (ert-deftest file-notify-test09-watched-file-in-watched-dir ()
   "Watches a directory and a file in that directory separately.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]