emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] scratch/so-long f3189b6: fixup! Add so-long library


From: Phil
Subject: [Emacs-diffs] scratch/so-long f3189b6: fixup! Add so-long library
Date: Fri, 28 Jun 2019 22:47:42 -0400 (EDT)

branch: scratch/so-long
commit f3189b6de1ee255600edc305ee9b9ee7260b2f3f
Author: Phil Sainty <address@hidden>
Commit: Phil Sainty <address@hidden>

    fixup! Add so-long library
    
    Use internal function naming for advice.
---
 lisp/so-long.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/so-long.el b/lisp/so-long.el
index 1a6104d..278ad06 100644
--- a/lisp/so-long.el
+++ b/lisp/so-long.el
@@ -1214,9 +1214,9 @@ Use \\[so-long-customize] to configure the behaviour."
              (or (so-long-original 'major-mode) "<unknown>")
              (substitute-command-keys "\\[so-long-revert]"))))
 
-(defun so-long-change-major-mode ()
+(defun so-long--change-major-mode ()
   ;; Advice, enabled with:
-  ;; (advice-add 'so-long-mode :before #'so-long-change-major-mode)
+  ;; (advice-add 'so-long-mode :before #'so-long--change-major-mode)
   ;;
   ;; n.b. `major-mode-suspend' and `major-mode-restore' are new in Emacs 27, 
and
   ;; related to what we're doing here; but it's not worth going to the effort 
of
@@ -1233,7 +1233,7 @@ This advice acts before `so-long-mode', with the previous 
mode still active."
     ;; Remember the original major mode, regardless.
     (so-long-remember 'major-mode)))
 
-(advice-add 'so-long-mode :before #'so-long-change-major-mode)
+(advice-add 'so-long-mode :before #'so-long--change-major-mode)
 
 (defun so-long-after-change-major-mode ()
   "Run by `so-long-mode' in `after-change-major-mode-hook'.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]