emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 9ee5af3 2/2: Adjust intptr_t advice


From: Paul Eggert
Subject: master 9ee5af3 2/2: Adjust intptr_t advice
Date: Sat, 14 Dec 2019 17:22:42 -0500 (EST)

branch: master
commit 9ee5af315098245d9f58eb5562dca6997cab4426
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>

    Adjust intptr_t advice
    
    * doc/lispref/internals.texi (C Integer Types): Say to prefer
    uintptr_t when pointer arithmetic might overflow intptr_t.
---
 doc/lispref/internals.texi | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/doc/lispref/internals.texi b/doc/lispref/internals.texi
index 8c55f4e..2a4e64d 100644
--- a/doc/lispref/internals.texi
+++ b/doc/lispref/internals.texi
@@ -2825,12 +2825,14 @@ POSIX requires support only for values in the range 
@minus{}1 ..@:
 @code{SSIZE_MAX}.
 
 @item
-Prefer @code{intptr_t} for internal representations of pointers, or
+Normally, prefer @code{intptr_t} for internal representations of pointers, or
 for integers bounded only by the number of objects that can exist at
 any given time or by the total number of bytes that can be allocated.
-Currently Emacs sometimes uses other types when @code{intptr_t} would
-be better; fixing this is lower priority, as the code works as-is on
-Emacs's current porting targets.
+However, prefer @code{uintptr_t} to represent pointer arithmetic that
+could cross page boundaries.  For example, on a machine with a 32-bit
+address space an array could cross the 0x7fffffff/0x80000000 boundary,
+which would cause an integer overflow when adding 1 to
+@code{(intptr_t) 0x7fffffff}.
 
 @item
 Prefer the Emacs-defined type @code{EMACS_INT} for representing values



reply via email to

[Prev in Thread] Current Thread [Next in Thread]