emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 10a0941: ; Revert "; Add a note about a bottleneck"


From: Dmitry Gutov
Subject: master 10a0941: ; Revert "; Add a note about a bottleneck"
Date: Sun, 5 Jul 2020 21:32:04 -0400 (EDT)

branch: master
commit 10a0941f4dcc85d95279ae67032ec04463a44d59
Author: Dmitry Gutov <dgutov@yandex.ru>
Commit: Dmitry Gutov <dgutov@yandex.ru>

    ; Revert "; Add a note about a bottleneck"
    
    This reverts commit 9f9ce631a2ff44ebcb87b0b1390a21b13665db43.
    
    It's still a bottleneck, but so are mapcar (with its effect on GC) and
    concat. So our limits show in several places at once.
---
 lisp/progmodes/project.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 1882364..08798d8 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -396,8 +396,6 @@ backend implementation of `project-external-roots'.")
        (setq files
              (mapcar
               (lambda (file) (concat default-directory file))
-              ;; XXX: With large enough project, split-string becomes
-              ;; one of the bottlenecks.
               (split-string
                (apply #'vc-git--run-command-string nil "ls-files" args)
                "\0" t)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]